Skip to content

bookletic:0.3.2 #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

bookletic:0.3.2 #2815

wants to merge 15 commits into from

Conversation

harrellbm
Copy link
Contributor

I am submitting

  • a new package
  • an update for a package

Description: Maintenance release. Tested to be compatible with Typst 0.13.1 and minor documentation fixes.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot changed the title Bookletic:0.3.1 bookletic:0.3.1 Jul 30, 2025
@typst-package-check typst-package-check bot added the update A package update. label Jul 30, 2025
@saecki saecki self-assigned this Jul 31, 2025
saecki
saecki reviewed Jul 31, 2025
View reviewed changes
Copy link
Member

@saecki saecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I've left a few comments regarding the examples.

packages/preview/bookletic/0.3.1/example/example.pdf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will be very hard to discover, unless someone is browsing this repository directly. Could you either remove it or link to it in the readme?

@saecki saecki added the waiting-on-author Pull request waits on author label Aug 4, 2025
@typst-package-check typst-package-check bot changed the title bookletic:0.3.1 bookletic:0.3.2 Aug 7, 2025
@typst-package-check typst-package-check bot removed the waiting-on-author Pull request waits on author label Aug 7, 2025
@harrellbm
Copy link
Contributor Author

Let me know if there are any other outstanding issues that need fixed before merging!

@saecki
Copy link
Member

saecki commented Aug 11, 2025

Thanks, this fixes most things, and the failing package check is a false positive. But the example.pdf file is still not linked in the readme. Could you just remove it, since it can easily be reproduced by compiling the example?

@saecki saecki added the waiting-on-author Pull request waits on author label Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saecki saecki saecki left review comments

Assignees

@saecki saecki

Labels

update A package update. waiting-on-author Pull request waits on author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harrellbm @saecki